gh-117716: Fix wave RIFF padding for data chunks#145237
Open
mbeijen wants to merge 1 commit intopython:mainfrom
Open
gh-117716: Fix wave RIFF padding for data chunks#145237mbeijen wants to merge 1 commit intopython:mainfrom
mbeijen wants to merge 1 commit intopython:mainfrom
Conversation
wave.Wave_write now writes the required RIFF pad byte when the data chunk size is odd. Update RIFF chunk size calculations in both header writing and header patching so they include the alignment pad byte when present. Add a regression test in test_wave.py that verifies odd-sized writes are padded, RIFF size is correct, and roundtrip reads preserve frame data.
a59aae9 to
f8ff230
Compare
Member
|
Looking at the document referenced in the issue (emphasis mine):
In this PR, the size includes the padding byte. Which is right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wave.Wave_write now writes the required RIFF pad byte when the data chunk size is odd.
Update RIFF chunk size calculations in both header writing and header patching so they include the alignment pad byte when present.
Add a regression test in test_wave.py that verifies odd-sized writes are padded, RIFF size is correct, and roundtrip reads preserve frame data.
Wave_writedoes not writepad byte#117716